Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CSS in the CLI. #9

Merged
merged 3 commits into from
Jun 17, 2023
Merged

Add support for CSS in the CLI. #9

merged 3 commits into from
Jun 17, 2023

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Jun 16, 2023

No description provided.

@lukaslueg
Copy link
Owner

Thanks for the PR. One nit and a failure in CI

@lukaslueg
Copy link
Owner

Could you address the nit mentioned above as well?

@mamcx
Copy link
Contributor Author

mamcx commented Jun 17, 2023

Could you address the nit mentioned above as well?

Which one? All the step passed...

@lukaslueg
Copy link
Owner

The review comment above. I fail to see why read_css should take an Option<T> just to pass through the None-case. The caller should filter None, probably something to the tune of css.unwrap_or(DEFAULT_CSS).

@lukaslueg lukaslueg merged commit 8cfdf29 into lukaslueg:master Jun 17, 2023
2 of 3 checks passed
@lukaslueg
Copy link
Owner

Thanks. I'll fix the clippy error myself. Would you care sharing the alternative css?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mamcx @lukaslueg