Improve test coverage (#215)

* removed return 0 from letterSpacing as there can not be any other value * updated test * add alias color to test
lukasoppermann · Jun 23, 2022 · eda4461 · eda4461
1 parent ab67bc3
commit eda4461
Show file tree

Hide file tree

Showing 4 changed files with 178 additions and 1 deletion.
diff --git a/src/transformer/standardTransformer.ts b/src/transformer/standardTransformer.ts
@@ -22,7 +22,6 @@ const letterSpacingToDimensions = (values): number => {
   if (values.letterSpacing.unit === 'percent') {
     return roundWithDecimals(values.fontSize.value * (values.letterSpacing.value / 100), 3)
   }
-  return 0
 }
 
 const widthToDimensionTransformer = ({ values }): StandardTokenDataInterface => ({

diff --git a/tests/unit/data/extractedFigmaTokens.data.ts b/tests/unit/data/extractedFigmaTokens.data.ts
@@ -454,6 +454,73 @@ export const extractedFigmaTokens = {
       }
     }
   },
+  fontLhPercent: {
+    name: 'font-lh-percent',
+    category: 'typography' as tokenCategoryType,
+    exportKey: 'typography' as tokenExportKeyType,
+    description: 'Font with lineheight in percent',
+    values: {
+      fontSize: {
+        value: 16,
+        unit: 'pixel',
+        type: 'number'
+      },
+      textDecoration: {
+        value: 'underline',
+        type: 'string'
+      },
+      fontFamily: {
+        value: 'Helvetica',
+        type: 'string'
+      },
+      fontWeight: {
+        value: 700,
+        type: 'number'
+      },
+      fontStyle: {
+        value: 'italic',
+        type: 'string'
+      },
+      fontStretch: {
+        value: 'normal',
+        type: 'string'
+      },
+      _fontStyleOld: {
+        value: 'bold italic',
+        type: 'string'
+      },
+      letterSpacing: {
+        value: 0.3,
+        unit: 'pixel',
+        type: 'number'
+      },
+      lineHeight: {
+        // @ts-ignore
+        value: 150,
+        unit: 'percent',
+        type: 'string'
+      },
+      paragraphIndent: {
+        value: 0,
+        unit: 'pixel',
+        type: 'number'
+      },
+      paragraphSpacing: {
+        value: 12,
+        unit: 'pixel',
+        type: 'number'
+      },
+      textCase: {
+        value: 'none',
+        type: 'string'
+      }
+    },
+    extensions: {
+      'org.lukasoppermann.figmaDesignTokens': {
+        exportKey: 'typography'
+      }
+    }
+  },
   /**
    * border
    */
@@ -522,6 +589,26 @@ export const extractedFigmaTokens = {
       }
     }
   },
+  aliasColor: {
+    name: 'aliasColor',
+    category: 'color' as tokenCategoryType,
+    exportKey: 'color' as tokenExportKeyType,
+    description: 'a color token',
+    values: [
+      {
+        fill: {
+          value: { r: 255, g: 230, b: 0, a: 1 },
+          type: 'color'
+        }
+      }
+    ],
+    extensions: {
+      'org.lukasoppermann.figmaDesignTokens': {
+        exportKey: 'color',
+        alias: '{color}'
+      }
+    }
+  },
   multiColor: {
     name: 'multiColor',
     category: 'color' as tokenCategoryType,
@@ -752,6 +839,23 @@ export const extractedFigmaTokens = {
       }
     }
   },
+  blurEffect: {
+    name: 'blur effect',
+    description: 'an effect token',
+    category: 'effect' as tokenCategoryType,
+    exportKey: 'effect' as tokenExportKeyType,
+    values: [{
+      effectType: {
+        value: 'blur',
+        type: 'string'
+      }
+    }],
+    extensions: {
+      'org.lukasoppermann.figmaDesignTokens': {
+        exportKey: 'effect'
+      }
+    }
+  },
   multiEffect: {
     name: 'multiEffect',
     description: 'a multi effect token',

diff --git a/tests/unit/data/transformedStandardTokens.data.ts b/tests/unit/data/transformedStandardTokens.data.ts
@@ -228,6 +228,56 @@ export const transformedStandardTokens = {
       value: 'underline'
     }
   },
+
+  fontLhPercent: {
+    name: 'font-lh-percent',
+    description: 'Font with lineheight in percent',
+    fontSize: {
+      value: 16,
+      type: 'dimension'
+    },
+    textDecoration: {
+      value: 'underline',
+      type: 'string'
+    },
+    fontFamily: {
+      value: 'Helvetica',
+      type: 'string'
+    },
+    fontWeight: {
+      value: 700,
+      type: 'number'
+    },
+    fontStyle: {
+      value: 'italic',
+      type: 'string'
+    },
+    fontStretch: {
+      value: 'normal',
+      type: 'string'
+    },
+    letterSpacing: {
+      value: 0.3,
+      type: 'dimension'
+    },
+    lineHeight: {
+      // @ts-ignore
+      value: 24,
+      type: 'dimension'
+    },
+    paragraphIndent: {
+      value: 0,
+      type: 'dimension'
+    },
+    paragraphSpacing: {
+      value: 12,
+      type: 'dimension'
+    },
+    textCase: {
+      value: 'none',
+      type: 'string'
+    }
+  },
   /**
    * border
    */
@@ -288,6 +338,18 @@ export const transformedStandardTokens = {
       }
     }
   },
+  aliasColor: {
+    name: 'aliasColor',
+    description: 'a color token',
+    type: 'color',
+    value: '{{color}}',
+    extensions: {
+      'org.lukasoppermann.figmaDesignTokens': {
+        exportKey: 'color',
+        alias: '{color}'
+      }
+    }
+  },
   multiColor: {
     name: 'multiColor',
     extensions: {
@@ -383,6 +445,15 @@ export const transformedStandardTokens = {
       spread: 0
     }
   },
+  blurEffect: {
+    name: 'blur effect',
+    extensions: {
+      'org.lukasoppermann.figmaDesignTokens': {
+        exportKey: 'effect'
+      }
+    },
+    description: 'an effect token'
+  },
   multiEffect: {
     name: 'multiEffect',
     extensions: {

diff --git a/tests/unit/transformer.standardTransformer.test.ts b/tests/unit/transformer.standardTransformer.test.ts
@@ -12,13 +12,16 @@ describe('standard Transfomer', () => {
   test('multi grid token', () => expect(transformer(extractedFigmaTokens.multiGrid)).toStrictEqual(transformedStandardTokens.multiGrid))
   test('font token', () => expect(transformer(extractedFigmaTokens.font)).toStrictEqual(transformedStandardTokens.font))
   test('typography token', () => expect(transformer(extractedFigmaTokens.typography)).toStrictEqual(transformedStandardTokens.typography))
+  test('font with lineheight percent', () => expect(transformer(extractedFigmaTokens.fontLhPercent)).toStrictEqual(transformedStandardTokens.fontLhPercent))
   test('color token', () => expect(transformer(extractedFigmaTokens.color)).toStrictEqual(transformedStandardTokens.color))
+  test('alias color token', () => expect(transformer(extractedFigmaTokens.aliasColor)).toStrictEqual(transformedStandardTokens.aliasColor))
   test('multi color token', () => expect(transformer(extractedFigmaTokens.multiColor)).toStrictEqual(transformedStandardTokens.multiColor))
   test('gradient token', () => expect(transformer(extractedFigmaTokens.gradient)).toStrictEqual(transformedStandardTokens.gradient))
   test('color and gradient token', () => expect(transformer(extractedFigmaTokens.colorAndGradient)).toStrictEqual(transformedStandardTokens.colorAndGradient))
   test('gradient and color', () => expect(transformer(extractedFigmaTokens.gradientAndColor)).toStrictEqual(transformedStandardTokens.gradientAndColor))
   test('border token', () => expect(transformer(extractedFigmaTokens.border)).toStrictEqual(transformedStandardTokens.border))
   test('effect token', () => expect(transformer(extractedFigmaTokens.effect)).toStrictEqual(transformedStandardTokens.effect))
+  test('blur effect token', () => expect(transformer(extractedFigmaTokens.blurEffect)).toStrictEqual(transformedStandardTokens.blurEffect))
   test('multi effect token', () => expect(transformer(extractedFigmaTokens.multiEffect)).toStrictEqual(transformedStandardTokens.multiEffect))
   test('motion token', () => expect(transformer(extractedFigmaTokens.motion)).toStrictEqual(transformedStandardTokens.motion))
   test('opacity token', () => expect(transformer(extractedFigmaTokens.opacity)).toStrictEqual(transformedStandardTokens.opacity))