Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent update breaks export variables #265

Closed
ryanzec opened this issue Aug 14, 2023 · 5 comments
Closed

Recent update breaks export variables #265

ryanzec opened this issue Aug 14, 2023 · 5 comments

Comments

@ryanzec
Copy link
Contributor

ryanzec commented Aug 14, 2023

With the latest version, I am no longer able to export tokens when I include variables, I just get this error:

Screen Shot 2023-08-14 at 7 23 55 AM

I tried both enabling and disabling the new mode reference feature.

@ryanzec
Copy link
Contributor Author

ryanzec commented Aug 14, 2023

This seems to be related to this change:
https://github.com/lukasoppermann/design-tokens/pull/263/files#diff-ebe8de5eee60114c6d10956453c31e12c53c196abfeca396733d76a1d52465f3L261
I believe the escaping is require in that context (my regex is not the best but changing it back allow me to export variables again).

@ryanzec
Copy link
Contributor Author

ryanzec commented Aug 14, 2023

It does seem like the linting thinks those are not needed so not really sure what is going on with it.

@ryanzec
Copy link
Contributor Author

ryanzec commented Aug 14, 2023

Ok, so it seem like one of the character should be escape but all escape was removed, it seems like this regex works : /^{[\w\s.\-_/@+&:]*}$/ : and passes linting

@lukasoppermann
Copy link
Owner

Just published the change, can you verify if it works?

@ryanzec
Copy link
Contributor Author

ryanzec commented Aug 14, 2023

Yea, that latest version seems good

@ryanzec ryanzec closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants