Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded collections containing a specific string from the export target #275

Conversation

hayawata3626
Copy link
Contributor

Related #270

Collections
スクリーンショット 2023-09-17 21 57 57

Exported JSON
スクリーンショット 2023-09-17 21 58 56

ryanzec and others added 3 commits August 23, 2023 23:07
…g style dictionary (lukasoppermann#261)

* added proper support for variable alias when transforming tokens using style dictionary

* process alias modes when modeReference is enabled

* Update src/utilities/getVariables.ts

* Update src/utilities/getVariables.ts

---------

Co-authored-by: Lukas Oppermann <lukasoppermann@github.com>
@coveralls
Copy link

coveralls commented Sep 17, 2023

Pull Request Test Coverage Report for Build 6260862645

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 66.374%

Totals Coverage Status
Change from base Build 6156117612: -0.09%
Covered Lines: 496
Relevant Lines: 732

💛 - Coveralls

@hayawata3626
Copy link
Contributor Author

@lukasoppermann
The following part of the collection contains prefixes _ and . in the following section, should I add a description that does not export the collection as well?
スクリーンショット 2023-09-21 19 40 53

@lukasoppermann
Copy link
Owner

@hayawata3626 yes please. 🙏

@hayawata3626
Copy link
Contributor Author

@lukasoppermann
I added. 🙏

@lukasoppermann
Copy link
Owner

lukasoppermann commented Sep 22, 2023

Hey, first of all, could you rebase so that you only have relevant commits?

Additionally, can you update your PR to change the code to this: 343e187
I can not push to your PR. If this does not work I can create a PR for this, but I am happy to merge yours if you can adjust the files.

@hayawata3626
Copy link
Contributor Author

@lukasoppermann
Thank you for your reply.
I will modify it!

@hayawata3626
Copy link
Contributor Author

@lukasoppermann
Sorry, I responded with another PR. Please review.
I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants