#561 replace travis with GitHub action #562
Conversation
- renamed travis script in `package.json` to `github-build`
…om/greenkeeperio/greenkeeper-lockfile says, that greenkeeper has build-in support, now
|
I changed the version declaration to a string. Otherwise the actions always takes node version 10 ;-) |
- renamed travis script in `package.json` to `github-build` - removed greenkeeper-lockfile from actions, because https://github.com/greenkeeperio/greenkeeper-lockfile says, that greenkeeper has build-in support, now - updated to node version 14, because we used it in travis, too - we need a string for node-version, otherwise it will take version 10 automatically - added some globals to make standard green - added coveralls action to github action configuration - added es-disable an export in `store.ts` to make standard green - added HTMLElement to global to make the standard green - changed syntax for creating lcov - removed `.coveralls.yml` because we dont need it anymore - removed accidentally added reporter from `package.json` - we dont need coveralls anymore because of the action, so I removed it completely as a dependency changed badge to github actions instead of travis
…ce-travis-with-github-action
|
Hey @atodorov this should satisfy your change request so we can merge it, correct? |
atodorov
changed the title
|
@Gontrum can you rebase on top of the latest master and resolve the conflicts please. |
- renamed travis script in `package.json` to `github-build` - removed greenkeeper-lockfile from actions, because https://github.com/greenkeeperio/greenkeeper-lockfile says, that greenkeeper has build-in support, now - updated to node version 14, because we used it in travis, too - we need a string for node-version, otherwise it will take version 10 automatically - added some globals to make standard green - added coveralls action to github action configuration - added es-disable an export in `store.ts` to make standard green - added HTMLElement to global to make the standard green - changed syntax for creating lcov - removed `.coveralls.yml` because we dont need it anymore - removed accidentally added reporter from `package.json` - we dont need coveralls anymore because of the action, so I removed it completely as a dependency - changed badge to github actions instead of travis
…b.com/Gontrum/html5sortable into 561-replace-travis-with-github-action
Sure :-) |
|
@lukasoppermann I don't see any obvious conflicts here but I can't "Rebase & merge". The only available options for me are "Merge pull request (with a merge commit)" or "Squash and merge". |
|
@atodorov same here. I always "squash & merge" in any case, as it keeps the history a bit more clean & understandable. Does anything speak against squash & merge? |
FTR: I think the issue here was a merge commit in the PR itself. I personally prefer "Rebase & merge" to keep the history clear and also keep the individual commits separate so we can trace back history more granularly. In this particular case I agree squash was the right thing to do since there were many commits fixing items from the code review process or adding changes missing from the original commit. |
|
@atodorov thanks for the hint with the merge commit, I will keep that in mind. |
|
@atodorov so if a PR has multiple commits that make sense by themselves I agree with the "Rebase & merge". Often though the PR history is not cleaned up. But we could ask for a clean history as well. 👍 |
Hi everyone,
I'm not 100% sure if it fits like this. Actually I wanted to resolve #561 . Maybe you have some tips for me:
npm run standard, but this happens inmastertoo. Should I just ignore that?greenkeeper-lockfilefrom the action, because it says here https://github.com/greenkeeperio/greenkeeper-lockfile that this is now build-in.Does it fit otherwise?
Best regards