Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential change to address Issue#456 #677

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Potential change to address Issue#456 #677

merged 1 commit into from
Mar 6, 2021

Conversation

Lemonsavery
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.864% when pulling 43f1d7b on Lemonsavery:patch-1 into 0b73cd1 on lukasoppermann:master.

@Lemonsavery
Copy link
Contributor Author

I encountered the same issue as described in #456, and this was part of my fix for it. My issue would occur while using Chrome, but not while using Edge.

@lukasoppermann
Copy link
Owner

Hey @Lemonsavery
thank you very much for the PR. I will have to look into it to to make sure it has not repercussions and hope to be able to merge it very soon. Great. 👍

@lukasoppermann
Copy link
Owner

Hey @Lemonsavery can you please explain the issue it is solving again? I have the feeling the issue mentioned in the ticket persists, but this may be due to me not really getting how to reproduce it. 😁

@Lemonsavery
Copy link
Contributor Author

Lemonsavery commented Mar 5, 2021

@lukasoppermann Here are two gifs of rows being dragged and dropped quickly/normal. Drag events are printed to Chrome DevTools console. When dragged and dropped too quickly, the 'drop' event can occur before the placeholder row is in place. insertNode() then tries to use the placeholder as referenceNode, but referenceNode.nextElementSibling is null, so the dragged row vanishes. Then, later, the placeholder row is created.

buggy drag correct drag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants