-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
@lukasroegner I created a PR however I see that we have some conflicts. |
@lukasroegner Conflicts are now resolved and includes the changes for stabilizing the playing state while keeping the logic for current app active. |
Thanks, I'll review the changes! |
@lukasroegner Thanks! Let me know if you have any questions. Never programmed TypeScript before, but I tested the code on tvOS 14.2 and seems to be working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the PR, this is a clean and simple solution! I've added some comments, mostly minor things (comments, styles, etc.).
One thing that is missing:
The platform.ts
, line 71 and 76, is missing checks if the array of app play/pause switches is provided.
@lukasroegner I pushed the changes to the branch and should resolve all the comments. Thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some style issues, otherwise perfect! I'll merge to master after those minor things are resolved. Thanks again!
@lukasroegner Done, ready to be merged to Master! |
Updated documentation, added the logic for multi button support and included wildcards for bundleIndentifier.
A pull request for the the following topic: #62 (comment)