Skip to content
This repository has been archived by the owner on Jan 29, 2022. It is now read-only.

Add multi button support. #66

Merged
merged 18 commits into from
Sep 27, 2020
Merged

Conversation

Luitwieler
Copy link
Contributor

Updated documentation, added the logic for multi button support and included wildcards for bundleIndentifier.

A pull request for the the following topic: #62 (comment)

@Luitwieler
Copy link
Contributor Author

@lukasroegner I created a PR however I see that we have some conflicts.

@Luitwieler
Copy link
Contributor Author

@lukasroegner Conflicts are now resolved and includes the changes for stabilizing the playing state while keeping the logic for current app active.

@lukasroegner
Copy link
Owner

Thanks, I'll review the changes!

@Luitwieler
Copy link
Contributor Author

Luitwieler commented Sep 27, 2020

@lukasroegner Thanks! Let me know if you have any questions. Never programmed TypeScript before, but I tested the code on tvOS 14.2 and seems to be working fine.

Copy link
Owner

@lukasroegner lukasroegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR, this is a clean and simple solution! I've added some comments, mostly minor things (comments, styles, etc.).

One thing that is missing:
The platform.ts, line 71 and 76, is missing checks if the array of app play/pause switches is provided.

README.md Show resolved Hide resolved
config.schema.json Outdated Show resolved Hide resolved
src/lib/clients/apple-tv-client.ts Outdated Show resolved Hide resolved
src/lib/clients/apple-tv-client.ts Outdated Show resolved Hide resolved
src/lib/clients/apple-tv-client.ts Outdated Show resolved Hide resolved
src/lib/clients/apple-tv-client.ts Show resolved Hide resolved
src/lib/configuration/device-configuration.ts Outdated Show resolved Hide resolved
src/lib/controllers/apple-tv-controller.ts Outdated Show resolved Hide resolved
src/lib/controllers/apple-tv-controller.ts Outdated Show resolved Hide resolved
src/lib/controllers/apple-tv-controller.ts Outdated Show resolved Hide resolved
@Luitwieler
Copy link
Contributor Author

Luitwieler commented Sep 27, 2020

@lukasroegner I pushed the changes to the branch and should resolve all the comments. Thanks for the feedback!

Copy link
Owner

@lukasroegner lukasroegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some style issues, otherwise perfect! I'll merge to master after those minor things are resolved. Thanks again!

README.md Outdated Show resolved Hide resolved
src/lib/configuration/appplaypause-configuration.ts Outdated Show resolved Hide resolved
src/lib/configuration/appplaypause-configuration.ts Outdated Show resolved Hide resolved
src/lib/configuration/appplaypause-configuration.ts Outdated Show resolved Hide resolved
src/lib/configuration/appplaypause-configuration.ts Outdated Show resolved Hide resolved
src/lib/controllers/apple-tv-controller.ts Outdated Show resolved Hide resolved
src/lib/controllers/apple-tv-controller.ts Outdated Show resolved Hide resolved
src/lib/controllers/apple-tv-controller.ts Outdated Show resolved Hide resolved
src/lib/controllers/apple-tv-controller.ts Outdated Show resolved Hide resolved
@Luitwieler
Copy link
Contributor Author

@lukasroegner Done, ready to be merged to Master!

@lukasroegner lukasroegner merged commit df240de into lukasroegner:master Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants