Use unaligning vertex in Linear polymer #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: #156
Requested Reviewers: @lukasturcani
Note for Reviewers: If you accept the review request add a 馃憤 to this post
This PR makes no changes visible to the user but allows the user to place molecules like
BrCBron thepolymer.lineartopology graph usingUnaligningVertex. This is handled by the Linear initializer when defining vertices (all vertices with building blocks that only have one placer are converted to a UnaligningVertex - same as in Cof and Cage).src/stk/molecular/topology_graphs/polymer/linear/linear.py:_get_building_block_vertices: Added a check for whether each vertex should be an UnaligningVertex.src/stk/molecular/topology_graphs/polymer/linear/vertices.py:UnaligningVertex: Added new init class method.Two new tests added for vertex and molecule fixture.