Update test environment and Spindry version (#422) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers: @lukasturcani This commit just updates the usage of `Spindry` in `stk` to fit the new interface. Only a minor change was required, there is no longer the ability to change the sigma values used in `stk.Spinner()` because these are now set to the atom radii based on `stk.Atom.__class__.__name__` (this was already handled in the interface).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: @lukasturcani
This commit just updates the usage of
Spindryinstkto fit the newinterface. Only a minor change was required, there is no longer the
ability to change the sigma values used in
stk.Spinner()becausethese are now set to the atom radii based on
stk.Atom.__class__.__name__(this was already handled in theinterface).