Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to angular8 #286

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

osenouci
Copy link

The gallery needs to be updated to angular version 8 to avoid vulnerabilities and also to use the latest version of Hammer.JS.

If your angular application uses the latest angular material then you want to have the last version of hammer.js.

What has been done in this branch

  1. Update angular to version 8.
  2. Fix the gulp script to work with recent angular versions.
  3. Update @ViewChild decorator to be compatible with angular 8+.

@osenouci
Copy link
Author

Hello @lukasz-galka,

When do you think this could be merged and released ?

@woteska
Copy link

woteska commented Nov 11, 2019

Any update on this? @lukasz-galka

@yuniers yuniers mentioned this pull request Nov 23, 2019
@kolkov
Copy link

kolkov commented Nov 24, 2019

https://github.com/kolkov/ngx-gallery I try to recreate this package under Angular 8 library project.
This worked, but I see one minor bug when click on arrows. Try this. PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants