Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 support #304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nOstap
Copy link

@nOstap nOstap commented Feb 11, 2020

This pull request removes old Renderer references which are no longer supported by Angular 9.

@kolkov
Copy link

kolkov commented Feb 11, 2020

https://github.com/kolkov/ngx-gallery try this please.

@f22hd
Copy link

f22hd commented Feb 24, 2020

Can't waiting to merge these changes into master.
Thank you @nOstap

@nOstap
Copy link
Author

nOstap commented Feb 24, 2020 via email

@DevNaveen
Copy link

DevNaveen commented Mar 8, 2020

Please merge the changes.

@EloyRoura
Copy link

Would be great to have this merged :)

@nOstap
Copy link
Author

nOstap commented Mar 19, 2020 via email

@abrahamjoseph
Copy link

abrahamjoseph commented Apr 11, 2020

@lukasz-galka can you merge this PR which will resolve render error. This will help us to migrate our application to angular 9

@nOstap
Copy link
Author

nOstap commented Apr 11, 2020

For anyone who waits for this to be merged, I would recommend to Use Andrey Kolkov library is fully compatible with ngx-gallery and works with Angular 9. https://github.com/kolkov/ngx-gallery

@AlexRebula
Copy link

This seems like a great component and great effort from the owner and contributors. Github is great and I love it when developers can contribute. HOWEVER, it is kind of disheartening when owners cannot anymore follow up on contributions and get the time to merge. What can you do... life... :) Mostly I noticed this is because the owners will get busy with their work/life. Happened to me too. But yes it would be great for this to be merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants