Fixed script termination when an API fork compare returns '404 Not Found' #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…und' (e.g. user does not exist any longer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an user does not exist any longer, the API fork compare returns the HTTP error code 404 Not Found and throws an exception that terminates the comparison. This error can be reproduced by running the script for the repository "dsplaisted/strongnamer" where the listed owner "ProgrammerAndHacker" seems not to exist anymore.
This quick and dirty fix just ignores that issue. If there is a better way, I am open to suggestions.