Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
As these consist only of facts required for interoperability, they are not copyrightable.
- Loading branch information
As these consist only of facts required for interoperability, they are not copyrightable.
9a69a31There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you a complete idiot?
You've copied all the code directly out of their *.h files and removed their copyright
Copyright (c) 2008 - 2009 Advanced Micro Devices, Inc.
9a69a31There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't code, just interfaces, which are not copyrightable at all.
9a69a31There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you are saying that AMD cannot put
Copyright (c) 2008 - 2009 Advanced Micro Devices, Inc.
At the top of the files you have copied - since you say it isn't valid - and you are allowed to copy it and remove that copyright? ...
9a69a31There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There actually are several court cases that support luke's statement regarding .h interfaces... however, removing attribution from any previously created work is a pretty crappy practice.
9a69a31There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ktiedt Technically speaking, while the symbol names came from ADL (for compatibility), I did take the effort to redo the header in a cleaner way. IIRC, AMD's SDK uses #define macros for everything. These free header files use proper C enums where it makes sense, and bitshifts where I've guessed the values represented bitfields. You're welcome to compare it with the ADL SDK: I'd be surprised if I got every guess right (in particular, some of the values are 1 or 2, which are impossible to differentiate from a bitfield without reverse engineering the library itself). These headers in fact represent hours of my own work too, but since they are statements-of-fact and not copyrightable, I didn't think to add attribution at the time. I'll add something in there if it makes people happier.