Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display an informational notice if the BFGMiner window is hidden #434

Closed
wants to merge 1 commit into from

Conversation

luke-jr
Copy link
Owner

@luke-jr luke-jr commented Apr 22, 2014

This is to combat malware embedding BFGMiner.

@luke-jr
Copy link
Owner Author

luke-jr commented Apr 22, 2014

@nwoolls Will this make problems for MultiMiner and/or other frontends?

@nwoolls
Copy link
Contributor

nwoolls commented Apr 22, 2014

I'll need to test it but, if it does what it seems to do, yes this would effectively "break" MultiMiner in the eyes of users.

MultiMiner starts any number of BFGMiner instances to mine, depending on configuration. So if this displays on startup, that means a MultiMiner user pressing the "Start" button to start mining would see anywhere from 1, to 2, to N number of these prompts.

On top of that, one of the key features in MultiMiner is that it will restart BFGMiner unattended for any number of reasons, either due to crash or low Effective Hashrate etc. The upshot being that this "feature" of MultiMiner (restarting BFGMiner unattended) would be broken by dialogs being shown each time it happens.

@luke-jr
Copy link
Owner Author

luke-jr commented May 2, 2014

Seems this would be problematic, closing unmerged.

@luke-jr luke-jr closed this May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants