-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zeusminer: support added for ZeusMiner scrypt ASICs #471
zeusminer: support added for ZeusMiner scrypt ASICs #471
Conversation
@@ -529,7 +529,7 @@ bool icarus_detect_custom(const char *devpath, struct device_drv *api, struct IC | |||
icarus_close(fd); | |||
|
|||
bin2hex(nonce_hex, nonce_bin, sizeof(nonce_bin)); | |||
if (strncmp(nonce_hex, info->golden_nonce, 8)) | |||
if (!info->ignore_golden_nonce && strncmp(nonce_hex, info->golden_nonce, 8)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to even send/receive the golden packets if the result is ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not all of them, only a small portion. Most work fine and respond to the golden OB. Some do not, but still hash fine if you tell them to get on with it. Verified myself with user HW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, my point is why bother sending and waiting for the response, when you're just going to ignore it? Why not just skip that and add_cgpu etc (when this flag is set)?
BTW all Zeus gen 1 chips have 8 cores and will probably be that way for a while...might not want to have the core # user configurable |
Sorry folks - my Push hid some comments. @jstefanop please test this latest code if you can and verify if your diff fixes are still required or if Luke's suggestions work. |
Diff changes and your last commits look good! |
Score! Thanks so much for confirming. |
@jstefanop Can you test the zeusminer branch on my github repo? |
SSH in if you need to Luke. There's a Zeus plugged in. -----Original Message----- @jstefanop Can you test the zeusminer branch on my github repo? |
--set zus:freq=XYZ (default 328)
--set zus:chips=X (default 6)
--set zus:cores=X (default 8)
--set zus:ignore_golden_nonce (don't check probe response - buggy HW/FW)