Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for useSuccessResponseCode:true in 4.x major release #1153

Closed
2 of 4 tasks
devnev opened this issue Dec 14, 2021 · 0 comments · Fixed by #1154
Closed
2 of 4 tasks

Remove need for useSuccessResponseCode:true in 4.x major release #1153

devnev opened this issue Dec 14, 2021 · 0 comments · Fixed by #1154
Labels
good first issue This issue could be an easy PR for those looking to help contribute help wanted

Comments

@devnev
Copy link
Contributor

devnev commented Dec 14, 2021

Sorting

  • I'm submitting a ...

    • bug report
    • feature request
    • support request
  • I confirm that I

    • used the search to make sure that a similar issue hasn't already been submit

Expected Behavior

As on #723, but enabled by default with the new major version bump.

Current Behavior

Back in #723 / #850 we added an option to make TSOA use the specified success codes by default, but left it as an option to avoid breaking anyone accidentally relying on current behaviour, despite the behaviour with the option intended likely being the expected behaviour.

Possible Solution

Remove the option entirely and have TSOA behave as if the option were enabled, in other words use the status code by default but allow overriding from the controller.

Context (Environment)

Version of the library: 3.9
Version of NodeJS: 14

  • Confirm you were using yarn not npm: [x]

Breaking change?

Yes

@WoH WoH added good first issue This issue could be an easy PR for those looking to help contribute help wanted labels Dec 14, 2021
devnev added a commit to devnev/tsoa that referenced this issue Dec 14, 2021
@WoH WoH closed this as completed in #1154 Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue could be an easy PR for those looking to help contribute help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants