Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions don't allow scalar / primitive values #958

Closed
egandro opened this issue Apr 5, 2021 · 3 comments · Fixed by #1040
Closed

Extensions don't allow scalar / primitive values #958

egandro opened this issue Apr 5, 2021 · 3 comments · Fixed by #1040
Labels
good first issue This issue could be an easy PR for those looking to help contribute help wanted

Comments

@egandro
Copy link
Contributor

egandro commented Apr 5, 2021

@Extension('x-internal','true')

Creates:

"x-internal": "true" as expected.

@Extension('x-internal',true) a primitive type like a bool / int won't be serialized

@WoH
Copy link
Collaborator

WoH commented Apr 10, 2021

This could be supported, as the spec says:

The value can be null, a primitive, an array or an object. Can have any valid JSON format value.

@WoH WoH added help wanted good first issue This issue could be an easy PR for those looking to help contribute labels Apr 10, 2021
@mhyeun
Copy link
Contributor

mhyeun commented Jul 22, 2021

Hi! I found the tsoa library to be really useful and was hoping to get into contributing to open-source projects.

Could I take on this issue?

@WoH
Copy link
Collaborator

WoH commented Jul 23, 2021

Sure! No need to ask, but esp. issues marked as "help wanted" are great candidates for PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue could be an easy PR for those looking to help contribute help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants