Allow null and primitive values in an Extension #1040

mhyeun · 2021-07-23T14:19:50Z

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you written unit tests?
Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)? (Already existed as InvalidExtensionControllerGenerator test suite)
This PR is associated with an existing issue?

Closing issues

Closes #958.

Test plan

Updated the Extension data being used in methodController.ts and updated the tests in metadata.spec.ts, schemaDetails.spec.ts and schemaDetails3.spec.ts. These tests now include null, primitive values, and their usage in objects and arrays.

mhyeun · 2021-07-23T14:22:23Z

packages/cli/src/metadataGeneration/initializer-value.ts

@@ -39,6 +39,8 @@ export const getInitializerValue = (initializer?: ts.Expression, typeChecker?: t
        return dateString;
      }
      return;
+    case ts.SyntaxKind.NullKeyword:
+      return null;


Without this case, null would fall to the default case, being returned as undefined.

WoH · 2021-07-31T15:59:16Z

LGTM, congrats and thank you for your first contribution!

mhyeun added 3 commits July 22, 2021 18:30

Allow null and scalar/primitive values to be used in an @extension

569be1e

Delete whitespace

cbce132

Delete whitespace in methodController.ts

3ec7500

mhyeun changed the title ~~Allow null and primitive values for Extension values~~ Allow null and primitive values in an Extension Jul 23, 2021

mhyeun commented Jul 23, 2021

View reviewed changes

WoH merged commit a202ded into lukeautry:master Jul 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow null and primitive values in an Extension #1040

Allow null and primitive values in an Extension #1040

mhyeun commented Jul 23, 2021

mhyeun Jul 23, 2021

WoH commented Jul 31, 2021

Allow null and primitive values in an Extension #1040

Allow null and primitive values in an Extension #1040

Conversation

mhyeun commented Jul 23, 2021

All Submissions:

mhyeun Jul 23, 2021

Choose a reason for hiding this comment

WoH commented Jul 31, 2021