Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #1012 - allow string[] to be used in an @Extension #1023

Merged
merged 2 commits into from Jun 25, 2021
Merged

closes #1012 - allow string[] to be used in an @Extension #1023

merged 2 commits into from Jun 25, 2021

Conversation

oliver-brm
Copy link
Contributor

All Submissions:

  • [✔️] Have you followed the guidelines in our Contributing document?
  • [✔️] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [✔️] Have you written unit tests?
  • [❌] Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)? (Already existed as InvalidExtensionControllerGenerator test suite)
  • [✔️] This PR is associated with an existing issue?

Closing issues

Closes #1012.

Test plan

The added test suite ValidExtensionControllerGenerator makes sure that @Extension declarations, similar to those we need to feed into Amazon API Gateway, do work. It's somewhat a double-check because without allowing string[] in @ExtensionType, TypeScript would not compile at all.

@@ -24,6 +24,14 @@ describe('Metadata generation', () => {
});
});

describe('ValidExtensionControllerGenerator', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WoH OK, I added the fixture/tests to methodController.ts, schemaDetails.spec.ts, schemaDetails3.spec.ts and metadata.spec.ts.

@WoH
Copy link
Collaborator

WoH commented Jun 25, 2021

LGTM, thanks for submitting a PR! 🚀

@WoH WoH merged commit 5cbd764 into lukeautry:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declaration of ExtensionType does not fit for Amazon API Gateway
2 participants