Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add TS 5.0 #1372

Merged
merged 4 commits into from
Mar 30, 2023
Merged

chore: Add TS 5.0 #1372

merged 4 commits into from
Mar 30, 2023

Conversation

WoH
Copy link
Collaborator

@WoH WoH commented Jan 31, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

@WoH WoH changed the title chore: Add TS 5.0 to CI chore: Add TS 5.0 Jan 31, 2023
@WoH
Copy link
Collaborator Author

WoH commented Feb 13, 2023

We probably want to have a Test suite that has esm/cjs + new decorators. They seem to work seemlessly, but having regression tests look like a reasonable investment

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Mar 16, 2023
@WoH WoH removed the Stale label Mar 17, 2023
@WoH WoH marked this pull request as ready for review March 30, 2023 16:16
@WoH WoH merged commit 6775ed3 into master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant