Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1351: default file size limit #1381

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Fix/1351: default file size limit #1381

merged 2 commits into from
Mar 30, 2023

Conversation

jackey8616
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
Fixes #1351.

@jackey8616 jackey8616 marked this pull request as ready for review February 9, 2023 17:03
@WoH
Copy link
Collaborator

WoH commented Feb 13, 2023

LGTM and I'd like to merge this, but I think we should consider this a breaking change. I am pretty comfortable shipping this alongside the TS 5.0 upgrades and bumping another major if you don't mind

@jackey8616
Copy link
Collaborator Author

I'm ok with that.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Mar 16, 2023
@jackey8616
Copy link
Collaborator Author

@WoH need help remove Stale label. thx.

@WoH WoH removed the Stale label Mar 17, 2023
@WoH WoH merged commit 5f68ef6 into lukeautry:master Mar 30, 2023
@jackey8616 jackey8616 deleted the fix/1351 branch January 15, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of @FileUpload adds a security sensitivity via multer()
2 participants