fix: enable compilerOptions.strict for all packages #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudunWA
force-pushed
the
awa/fix/strict-ts
branch
from
cd369ee
to
8bc64bd
Compare
WoH
reviewed
Jun 1, 2023
| }); | ||
| } | ||
| }); | ||
|
|
||
| return extensions; | ||
| } | ||
|
|
||
| function validateExtensionKey(key: string) { | ||
| if (key.indexOf('x-') !== 0) { | ||
| function validateExtensionKey(key: string): key is `x-${string}` { |
There was a problem hiding this comment.
I would prefer
asserts key is `x-${string}`This is more intuitive when throwing and avoids the throwing if/then/else.
Also gives rise to renaming this function to assertValidExtensionKey
There was a problem hiding this comment.
Cool, didn't know about that TS feature – it definitely looks better!
AudunWA
force-pushed
the
awa/fix/strict-ts
branch
from
8bc64bd
to
bb05596
Compare
AudunWA
force-pushed
the
awa/fix/strict-ts
branch
from
bb05596
to
9ff7d08
Compare
WoH
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closing issues
Fixes parts of #1165 ("Strict tsconfig in all packages" checkbox)
Own comments
This adds
strict: trueto alltsconfig.jsonfiles, and removes redundant options thatstrictenables.All resulting TS errors have been fixed, but some fixes might still hide already existing issues.
Note: I kept
noImplicitAny: falsefor tests, but I can remove it if we want full strictness for test code as well.