Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore undefined inside unions in supportPathDataType #1438

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

simllll
Copy link
Contributor

@simllll simllll commented Jun 14, 2023

fixes part of #1430

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

partially closes #1430

@simllll simllll closed this Jun 14, 2023
@simllll simllll reopened this Jun 14, 2023
@simllll
Copy link
Contributor Author

simllll commented Jun 19, 2023

@WoH I've also added a test, what do you think about this? Can we go this path?

@WoH
Copy link
Collaborator

WoH commented Jun 19, 2023

LGTM

@WoH WoH merged commit 30bc2e1 into lukeautry:master Jun 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use union types in query parameters definition
2 participants