Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1451: update @koa/multer import keyword in koa.hbs #1452

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

wazho
Copy link
Contributor

@wazho wazho commented Jul 16, 2023

Fixes this issue of #1451

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

closes #1451

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there wazho 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@WoH
Copy link
Collaborator

WoH commented Jul 17, 2023

#1283

or, specifically bc7dfae

We need the case distinction as there's no default export and we need to assume tsconfig that does not automagically fixes that. See the test issues as well

@wazho
Copy link
Contributor Author

wazho commented Jul 17, 2023

Already updated.

Thanks for the reminder 😄

@wazho
Copy link
Contributor Author

wazho commented Jul 18, 2023

Should we re-run the jobs of actions? The failing check had downloaded the dependencies with failure.

@WoH
Copy link
Collaborator

WoH commented Jul 19, 2023

LGTM

@WoH WoH merged commit 75fba31 into lukeautry:master Jul 19, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@koa/multer still use 'require' instead of 'import' in 'koa.hbs', lead to ESM project run failure
2 participants