fix: Validate intersection with multiple unions #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
connor-g-swyftx
commented
Oct 26, 2023
Comment on lines
-637
to
-639
| let currentCollector = { ...modelSchemass[outerIndex][0] }; | ||
| for (let innerIndex = outerIndex + 1; innerIndex < modelSchemass.length; innerIndex++) { | ||
| currentCollector = { ...this.intersectRefObjectModelSchemas([currentCollector], modelSchemass[innerIndex])[0] }; |
There was a problem hiding this comment.
The bug was caused on lines 637 and 639, using the first subschema from each schema of the intersection
|
Can you slap a return type onto buildContext (any/unknown is fine) to get the CI result? |
|
@WoH done, thanks |
WoH
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in validation of intersections with multiple unions. If the intersection includes at least three unions, only the first schema per union is accepted. One of the unions must have an overlapping required property to hit this bug.
I have written a failing test in f453161, and fixed it in f5f5fdb.
There has been similar work in the past on intersection validation in #888.
All Submissions:
Closing issues
Put
closes #XXXX(where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.Test plan
I've written parameterized tests to cover all valid schema combinations, and parameterized tests for invalid inputs covering invalid dataypes, missing required properties, and excess properties.