Fix koa ValidateError

[hpx7]

Closes #1333

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you written unit tests?
• Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
• This PR is associated with an existing issue?

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

• Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

I have verified this patch in my local tsoa + koa project

[github-actions]

Hello there hpx7 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

[hpx7]

@WoH would you be able to provide any guidance on the testing strategy for this?

[hpx7]

The Koa Server (with noImplicitAdditionalProperties turned on) tests are failing on master for me, it doesn't seem related to this PR

[WoH]

The Koa Server (with noImplicitAdditionalProperties turned on) tests are failing on master for me, it doesn't seem related to this PR

I think most of the invalid JSON errors are a consequence tbh.

[WoH]

I think we can just rethrow, right?
And set expose to true:
https://github.com/koajs/koa/blob/master/docs/api/context.md#ctxthrowstatus-msg-properties

[hpx7]

@WoH I managed to track down and fix the tests

[hpx7]

The current test failures seem related to some dependency upgrade. yarn install && yarn test works but yarn install --no-lockfile && yarn test fails. Curiously, yarn list seems to give back the same output either way.

Any ideas @WoH?

EDIT: The failure is that the test expects GenericRequest_Array_ but is getting GenericRequest_global.Array_ for genericNestedArrayKeyword1 and genericNestedArrayKeyword2

[WoH]

Yup, seems unrelated. I'll check what went wrong.

[hpx7]

Any luck so far @WoH ? Let me know if I can help