Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/hbs template logics extract to classes with implement interface #1545

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

jackey8616
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

I extracted the hbs template's logics into classes implements TemplateService interface.
Its better for future implementation on other frameworks.

@jackey8616
Copy link
Collaborator Author

@WoH I need re-run failed job again. oops.
I think we need to setup some try at actions.

@WoH WoH merged commit 579dc5e into lukeautry:master Jan 23, 2024
18 checks passed
@WoH
Copy link
Collaborator

WoH commented Jan 23, 2024

LGTM, thanks!

@jackey8616 jackey8616 deleted the refactor/hbs-template-interface branch January 28, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants