Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/eslint rules #1553

Merged
merged 8 commits into from
Feb 3, 2024
Merged

Fix/eslint rules #1553

merged 8 commits into from
Feb 3, 2024

Conversation

jackey8616
Copy link
Collaborator

@jackey8616 jackey8616 commented Feb 2, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

#1165

Fixed rules:

  • Regular file
    • @typescript-eslint/no-var-requires
    • @typescript-eslint/member-delimiter-style
    • @typescript-eslint/explicit-module-boundary-types
    • @typescript-eslint/no-non-null-assertion
    • no-shadow
  • tests/**/*.ts
    • @typescript-eslint/no-non-null-assertion
    • @typescript-eslint/no-unused-expressions
    • @typescript-eslint/restrict-template-expressions

@jackey8616 jackey8616 marked this pull request as ready for review February 2, 2024 01:19
@WoH WoH merged commit a954b4d into lukeautry:master Feb 3, 2024
18 checks passed
@jackey8616 jackey8616 deleted the fix/lint-rules branch February 3, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants