Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/template service #1555

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Refactor/template service #1555

merged 9 commits into from
Feb 13, 2024

Conversation

jackey8616
Copy link
Collaborator

@jackey8616 jackey8616 commented Feb 3, 2024 •
edited

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Changes

  • Type hint on TemplateService & Express/Hapi/Koa TemplateService as many as possible.
  • Simplify .hbs statements & add some type hint.

@jackey8616
Copy link
Collaborator Author

@WoH need re-run on this one, thx.

@WoH WoH merged commit 69f443b into lukeautry:master Feb 13, 2024
19 checks passed
@jackey8616 jackey8616 deleted the refactor/template-service branch February 14, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackey8616 @WoH