-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make coercion of body values configurable #1578
Merged
WoH
merged 11 commits into
lukeautry:master
from
friedow:feat/configure-implicit-body-coercion
Mar 24, 2024
Merged
feat: make coercion of body values configurable #1578
WoH
merged 11 commits into
lukeautry:master
from
friedow:feat/configure-implicit-body-coercion
Mar 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…icit-body-coercion
friedow
changed the title
Feat/configure implicit body coercion
feat: make coercion of body values configurable
Mar 11, 2024
Can you rebase this? |
WoH
reviewed
Mar 13, 2024
…icit-body-coercion
WoH
reviewed
Mar 13, 2024
WoH
reviewed
Mar 14, 2024
I've rebased the branch. Any more comments @WoH or is this ready to be merged? |
Since this is a larger one, I haven't had time to go though it in detail yet, but the structure LGTM. |
LGTM. |
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a config flag to enable / disable coercion on request bodies. The default for body coercion is enabled for this not to become a breaking change.
All Submissions:
Closing issues
This fixes #1563 and it resolves #1444.
If this is a new feature submission: