Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make coercion of body values configurable #1578

Merged
merged 11 commits into from
Mar 24, 2024

Conversation

friedow
Copy link
Contributor

@friedow friedow commented Mar 11, 2024

This will add a config flag to enable / disable coercion on request bodies. The default for body coercion is enabled for this not to become a breaking change.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

This fixes #1563 and it resolves #1444.

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project? @WoH ;)

@friedow friedow changed the title Feat/configure implicit body coercion feat: make coercion of body values configurable Mar 11, 2024
@WoH
Copy link
Collaborator

WoH commented Mar 13, 2024

Can you rebase this?

@friedow friedow requested a review from WoH March 13, 2024 14:37
@friedow friedow requested a review from WoH March 14, 2024 08:09
@friedow friedow requested a review from WoH March 14, 2024 09:46
@friedow
Copy link
Contributor Author

friedow commented Mar 18, 2024

I've rebased the branch. Any more comments @WoH or is this ready to be merged?

@WoH
Copy link
Collaborator

WoH commented Mar 18, 2024

Since this is a larger one, I haven't had time to go though it in detail yet, but the structure LGTM.
If there are no obvious things missing, I will merge this for a new minor probably this week.
@jackey8616 you have any notes?

@jackey8616
Copy link
Collaborator

LGTM.

@WoH WoH merged commit 33a3d20 into lukeautry:master Mar 24, 2024
18 checks passed
@friedow friedow deleted the feat/configure-implicit-body-coercion branch March 24, 2024 10:52
@friedow
Copy link
Contributor Author

friedow commented Mar 24, 2024

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants