Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap yamljs with yaml #1581

Merged
merged 2 commits into from Mar 17, 2024
Merged

fix: swap yamljs with yaml #1581

merged 2 commits into from Mar 17, 2024

Conversation

mamerruddin
Copy link
Contributor

@mamerruddin mamerruddin commented Mar 11, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

closes #1572

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

Change config file in tests/esm to yaml format just to show it loads config correctly.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there mamerruddin 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@mamerruddin mamerruddin marked this pull request as ready for review March 11, 2024 14:52
@mamerruddin
Copy link
Contributor Author

Closes #1572 . Swapped yamljs with yaml as it is actively maintained, and has zero dependency.

change config file to test yaml config
fix yaml parse
@mamerruddin
Copy link
Contributor Author

I have modify test to see it ables to load config correctly from a yaml config file.

@WoH WoH merged commit 37544bd into lukeautry:master Mar 17, 2024
18 checks passed
@mamerruddin mamerruddin deleted the swap-yamljs branch March 18, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snyk security vulnerability for inflight (one of tsoa indirect dependencies)
2 participants