Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata generation for computed properties names with enum values #1610

Merged
merged 1 commit into from Apr 16, 2024

Conversation

wilker7ribeiro
Copy link
Contributor

@wilker7ribeiro wilker7ribeiro commented Apr 12, 2024

This PR fixes the problem generating metadata for objects that have a computed property key using enum values mentioned in the issue #1264.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Closes #1264

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there wilker7ribeiro 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@wilker7ribeiro
Copy link
Contributor Author

Feel free to review and give me some advice since i'm not familiar with the code base

@wilker7ribeiro wilker7ribeiro changed the title fix metadata generation for computed properties names with enum values Fix metadata generation for computed properties names with enum values Apr 12, 2024
tests/fixtures/testModel.ts Outdated Show resolved Hide resolved
@WoH
Copy link
Collaborator

WoH commented Apr 14, 2024

LGTM, would you mind rebasing this?

@jackey8616 jackey8616 merged commit c954c92 into lukeautry:master Apr 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using enum values as interface property names results with "undefined" properties
3 participants