New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support controllers glob for dynamic imports #396
support controllers glob for dynamic imports #396
Conversation
add test as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple requested changes, but ultimately this is a wonderful addition. I’d like to review it more when I get more time on Monday, but this gives you a head start.
I would however like to know from @lukeautry why a glob file search wasn’t used in the first place.
By the way, I didn’t see a readme update for this. We’ll want that so people stop having to add the controllers to the index.ts.
add test for the error add documentation about this in the README
I found a couple of things, but ultimately this is a fantastic contribution. Thank you so much for doing this. :) I’m looking forward to merging this after you fix the one tests and return the variables to being readonly. |
you are right, just in our code style we separate the controller to router and controller |
…rollers' into FEATURE/support-auto-import-controllers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Thank you so much. This will certainly help to get more people to adopt tsoa. Great work! :)
Do you know when this will get published to the npm? I really need to use it :) |
For those that come accross this:
This was published in 2.4.7 I believe. I've added release notes. There will be a fix/enhancement coming in 2.4.9 |
FIX #395