Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unknown type (2.x) #559

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Add unknown type (2.x) #559

merged 1 commit into from
Jan 10, 2020

Conversation

WoH
Copy link
Collaborator

@WoH WoH commented Jan 10, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Closes #452

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

unknown and any are treated equally at the moment.
This should not be an issue since the main difference should be how ts handles type checking, which tsoa doesn't care about.
However, this means there's no new validation logic (same as any) or dataType etc.

Compatibility

New, backwards compatible feature, so I'm targeting master.
Will be ported for 3.x aswell.

@WoH WoH changed the title Add unknown type Add unknown type (2.x) Jan 10, 2020
@dgreene1 dgreene1 merged commit 5380a4f into lukeautry:master Jan 10, 2020
@WoH WoH added the ba label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for the unknown type
2 participants