Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing "not" in the docs: #584

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

edbrannin
Copy link
Contributor

inside your own code base (i.e. it does not live in ./node_modules)

This seems like there's a word missing, though I'm new to the project so I could be missing something.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
    • (Note: the document does not address documentation fixes)
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests? (N/A)
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)? (N/A)
  • This PR is associated with an existing issue? (Seems like overkill for a one-word docs change)

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

> inside your own code base (i.e. it does **not** live in `./node_modules`)

This seems like there's a word missing, though I'm new to the project so I _could_ be missing something.
@dgreene1
Copy link
Collaborator

Thank you so much @edbrannin for catching that and for submitting a PR. Also, it made me really happy to know that people are reading the docs. Glad to have you as part of the tsoa community! :)

@dgreene1 dgreene1 merged commit d81ec44 into lukeautry:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants