Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding static properties to model definition #638

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

dimitor115
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

Test plan
I've added unit tests that check if a static property is not included in the definition properties. (I also added a static property to TestClassModel.

@dimitor115
Copy link
Contributor Author

closes #627

@WoH WoH linked an issue Mar 31, 2020 that may be closed by this pull request
4 tasks
@WoH
Copy link
Collaborator

WoH commented Mar 31, 2020

LGTM, thank you very much!

@WoH WoH merged commit e620718 into lukeautry:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static properties in class based models get included
2 participants