Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SpecGen3: Render global tag descriptions if available #725

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

WoH
Copy link
Collaborator

@WoH WoH commented Jun 6, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

@WoH WoH requested a review from endor June 6, 2020 15:31
@WoH WoH changed the title fix: SpecGen3: Render global tags descriptions if available fix: SpecGen3: Render global tag descriptions if available Jun 6, 2020
@endor
Copy link
Collaborator

endor commented Jun 6, 2020

I wonder whether we should do some verification on the data the user provides to make sure it fits with the OpenAPI 3 specification.

@WoH
Copy link
Collaborator Author

WoH commented Jun 7, 2020

I wonder whether we should do some verification on the data the user provides to make sure it fits with the OpenAPI 3 specification.

Valid OAS3 Tags[] in case specVersion: 3 and valid OAS2 Tags[] in case specVersion: 2, but I'd agree that we may want to improve the support. Don't think it has to be part of this PR though.

@WoH WoH merged commit 1a7a9e5 into lukeautry:master Jun 7, 2020
@WoH WoH added the ba label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants