Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow array headers. Fixes #637 #864

Merged
merged 1 commit into from Dec 12, 2020
Merged

Allow array headers. Fixes #637 #864

merged 1 commit into from Dec 12, 2020

Conversation

aldenquimby
Copy link
Contributor

@aldenquimby aldenquimby commented Dec 9, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
Closes #637

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

  • Unit test covers header that's an array of strings

@aldenquimby aldenquimby changed the title Allow array headers Allow array headers. Fixes #637 Dec 9, 2020
@WoH WoH merged commit a4b9df5 into lukeautry:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set more than one cookie
2 participants