-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for file uploads #920
Add support for file uploads #920
Conversation
778a34e
to
e0af755
Compare
Can you add missing spec tests for OpenAPI 2/3? |
Will do |
cc56c48
to
00e3ef8
Compare
|
Addresses issues lukeautry#782 lukeautry#93
This adds more compatibility to different ts-configs
Includes cases which throw an error if the api is used wrongly
Add spec tests for v3
4e76081
to
43b2dcc
Compare
LGTM, thanks a lot for submitting the PR |
Thanks for this work! Have been using TSOA for nearly 3 years and very excited to see this land. Just some quick questions (I can put up a documentation PR after I've confirmed)
|
You can either use the old approach, adapt the route template, or submit a PR that allows you to hook into/provide the config we pass to multer. |
Addresses issues #782 #93
Took most code from #96 - so props to ezra-quemuel. sadly his code didnt got merged and it was too much of a hassle to merge his PR with the current code. This PR should fix this and add one of the most wanted features to tsoa
I decided not to store files send to the server, instead let the developer decide what to do with the received buffer.
All Submissions:
Closing issues
issues are already closed (because a work around existed)
If this is a new feature submission:
Potential Problems With The Approach
None
Test plan
Added 2 unit tests for each middleware (hapi, koa and express) one for testing whether the actual issue works, another one for testing multiple text-fields (plus multiple files) being uplaoded at once.