Skip to content

Commit

Permalink
webrtc wpt: make getUserMedia calls await
Browse files Browse the repository at this point in the history
removes the last directly promise-based usage of getUserMedia

BUG=836871

Change-Id: Ib0ef41b58c2fc3930d068d915cb569064db4542d
Reviewed-on: https://chromium-review.googlesource.com/1106618
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570005}
  • Loading branch information
fippo authored and Luke Bjerring committed Jun 26, 2018
1 parent 2823983 commit 669ff59
Showing 1 changed file with 26 additions and 38 deletions.
64 changes: 26 additions & 38 deletions webrtc/RTCPeerConnection-removeTrack.https.html
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,16 @@

}, 'addTransceiver - Calling removeTrack when connection is closed should throw InvalidStateError');

promise_test(t => {
promise_test(async t => {
const pc = new RTCPeerConnection();

t.add_cleanup(() => pc.close());

return navigator.mediaDevices.getUserMedia({ audio: true })
.then(mediaStream => {
const [track] = mediaStream.getTracks();
const sender = pc.addTrack(track, mediaStream);
const stream = await navigator.mediaDevices.getUserMedia({ audio: true });
const [track] = stream.getTracks();
const sender = pc.addTrack(track, stream);

pc.close();
assert_throws('InvalidStateError', () => pc.removeTrack(sender));
});
pc.close();
assert_throws('InvalidStateError', () => pc.removeTrack(sender));
}, 'addTrack - Calling removeTrack when connection is closed should throw InvalidStateError');

test(t => {
Expand All @@ -73,20 +70,17 @@

}, 'addTransceiver - Calling removeTrack on different connection that is closed should throw InvalidStateError');

promise_test(t => {
promise_test(async t => {
const pc = new RTCPeerConnection();

t.add_cleanup(() => pc.close());

return navigator.mediaDevices.getUserMedia({ audio: true })
.then(mediaStream => {
const [track] = mediaStream.getTracks();
const sender = pc.addTrack(track, mediaStream);
const stream = await navigator.mediaDevices.getUserMedia({ audio: true });
const [track] = stream.getTracks();
const sender = pc.addTrack(track, stream);

const pc2 = new RTCPeerConnection();
pc2.close();
assert_throws('InvalidStateError', () => pc2.removeTrack(sender));
});
const pc2 = new RTCPeerConnection();
pc2.close();
assert_throws('InvalidStateError', () => pc2.removeTrack(sender));
}, 'addTrack - Calling removeTrack on different connection that is closed should throw InvalidStateError');

/*
Expand All @@ -104,19 +98,16 @@

}, 'addTransceiver - Calling removeTrack on different connection should throw InvalidAccessError');

promise_test(t => {
promise_test(async t => {
const pc = new RTCPeerConnection();

t.add_cleanup(() => pc.close());

return navigator.mediaDevices.getUserMedia({ audio: true })
.then(mediaStream => {
const [track] = mediaStream.getTracks();
const sender = pc.addTrack(track, mediaStream);
const stream = await navigator.mediaDevices.getUserMedia({ audio: true });
const [track] = stream.getTracks();
const sender = pc.addTrack(track, stream);

const pc2 = new RTCPeerConnection();
assert_throws('InvalidAccessError', () => pc2.removeTrack(sender));
});
const pc2 = new RTCPeerConnection();
assert_throws('InvalidAccessError', () => pc2.removeTrack(sender));
}, 'addTrack - Calling removeTrack on different connection should throw InvalidAccessError')

/*
Expand All @@ -139,21 +130,18 @@

}, 'addTransceiver - Calling removeTrack with valid sender should set sender.track to null');

promise_test(t => {
promise_test(async t => {
const pc = new RTCPeerConnection();

t.add_cleanup(() => pc.close());

return navigator.mediaDevices.getUserMedia({ audio: true })
.then(mediaStream => {
const [track] = mediaStream.getTracks();
const sender = pc.addTrack(track, mediaStream);
const stream = await navigator.mediaDevices.getUserMedia({ audio: true });
const [track] = stream.getTracks();
const sender = pc.addTrack(track, stream);

assert_equals(sender.track, track);
assert_equals(sender.track, track);

pc.removeTrack(sender);
assert_equals(sender.track, null);
});
pc.removeTrack(sender);
assert_equals(sender.track, null);
}, 'addTrack - Calling removeTrack with valid sender should set sender.track to null');

/*
Expand Down

0 comments on commit 669ff59

Please sign in to comment.