Refund: removed description, added status attr

[fheyer]

Field description does not exist in Stripe API doc for and field status was missing.
see https://stripe.com/docs/api#refunds for reference

So i just renamed the field.

[andrewsolomon]

Thanks for the fix @fheyer! I just want to tread carefully in case people are already calling the description method. Could you change it to:

has 'status'              => (is => 'ro', isa => 'Maybe[Str]');
has 'description'         => (
    is      => 'ro',
    isa     => 'Maybe[Str]',
    default => sub {
        warn "Use of Net::Stripe::Refund->description is deprecated and will be removed in the next Net::Stripe release";
        return;
});

and also add a unit test like:

diff --git a/t/live.t b/t/live.t
index b6c51a4..308b144 100755
--- a/t/live.t
+++ b/t/live.t
@@ -171,6 +171,8 @@ Charges: {
         lives_ok { $refund = $stripe->refund_charge(charge => $charge->id, amount => 1000) }
             'refunding a charge works';
         is $refund->charge, $charge->id, 'returned charge object matches id';
+        isa_ok $refund, 'Net::Stripe::Refund';
+        is $refund->status, 'succeeded', 'status is "succeeded"';
         is $refund->amount, 1000, 'partial refund $10';
         lives_ok { $charge = $stripe->get_charge(charge_id => $charge->id) }
             'Fetching updated charge works';

Thanks!

[fheyer]

Hello Andrew,

thanks for your advice.
I added a deprecation warning for attribute description - however i declared this attribute lazy to get the warning only if the attribute is accessed.

My branch contains a merge of your master branch - i don't know if this hinders your final merge. If so i can provide a fresh pull request.

Best regards
Florian

[andrewsolomon]

Thanks @fheyer - it all merged smoothly. Cheers, Andrew