refactor(got): hTTP requests now use qs to generate query strings

lukecarr · May 21, 2020 · f78ce13 · f78ce13
1 parent de32873
commit f78ce13
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -57,6 +57,7 @@
     "@semantic-release/git": "^9.0.0",
     "@types/jest": "^25.2.3",
     "@types/node": "^14.0.4",
+    "@types/qs": "^6.9.3",
     "@typescript-eslint/eslint-plugin": "^2.34.0",
     "@typescript-eslint/parser": "^2.34.0",
     "codecov": "^3.7.0",
@@ -80,7 +81,8 @@
   },
   "dependencies": {
     "@babel/runtime": "^7.9.6",
-    "got": "^11.1.4"
+    "got": "^11.1.4",
+    "qs": "^6.9.4"
   },
   "config": {
     "commitizen": {

diff --git a/src/modules/index.ts b/src/modules/index.ts
@@ -1,3 +1,4 @@
+import qs from "qs";
 import { Client } from "../client";
 import FunctionResponse from "../functions/response";
 
@@ -38,10 +39,10 @@ export default abstract class Module {
     searchParams?: any
   ): Promise<FunctionResponse> {
     const response = await this.client.got.get("webservice/rest/server.php", {
-      searchParams: {
+      searchParams: qs.stringify({
         wsfunction,
-        ...searchParams,
-      },
+        ...searchParams
+      }),
       responseType: "json",
     });