Update window to version 4.2.6 #75

lukechilds · 2019-02-23T10:13:59Z

Resolves #74

Some properties will throw an error when accessed in certain conditions. We don't want to throw these errors, by accessing them when we setup the environemnt. Instead we should create getters for all window properties so they can throw the appropriate errors when accessed by user code.

coveralls · 2019-02-23T10:16:37Z

Coverage remained the same at 100.0% when pulling 3c2e69a on window-4.2.6 into 71aed2b on master.

* Require window@4.2.6 * Set global properties as getters Some properties will throw an error when accessed in certain conditions. We don't want to throw these errors, by accessing them when we setup the environemnt. Instead we should create getters for all window properties so they can throw the appropriate errors when accessed by user code. * Update expectedProperties.json for window@4.2.6

lukechilds added 3 commits February 23, 2019 16:42

Require window@4.2.6

91c2fcd

Update expectedProperties.json for window@4.2.6

3c2e69a

lukechilds mentioned this pull request Feb 23, 2019

Update window to the latest version 🚀 #72

Closed

lukechilds merged commit ffb7083 into master Feb 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update window to version 4.2.6 #75

Update window to version 4.2.6 #75

lukechilds commented Feb 23, 2019 •

edited

Loading

coveralls commented Feb 23, 2019

Update window to version 4.2.6 #75

Update window to version 4.2.6 #75

Conversation

lukechilds commented Feb 23, 2019 • edited Loading

coveralls commented Feb 23, 2019

lukechilds commented Feb 23, 2019 •

edited

Loading