Proposed ability to add sub & pseudo classes #93
Conversation
There was a problem hiding this comment.
This is a breaking change, which means it cannot proceed. clsx is heavily depended on & is feature-complete. Any behavior modifications would have to be surfaced as a separate, standalone module (eg, clsx/lite).
Also, on a general note, please try to refrain from code-style changes as it makes PRs harder to review.
| emptyObject: {}, | ||
| nonEmptyObject: {a: 1, b: 2}, | ||
| emptyList: [], | ||
| nonEmptyList: [1, 2, 3], | ||
| greaterZero: 1 |
There was a problem hiding this comment.
Removing these isn't a fix. The next assertion fails w/ these restored, which shows that this PR is a breaking change.
There was a problem hiding this comment.
Thanks, I didn't propose it as a non-breaking change. You are already doing versioned releases; this would be a new breaking release, no?
I removed those because they no longer apply as truthy - not as a fix, but a change.
I tried to keep the code style changes to a min.
|
Closing this PR for the reason mentioned above. You may open an issue to propose a Thank you for the work & suggestion! |
|
Thanks for checking it out :) I'll put it in a submodule and create a new PR. |
Instead of writing:
hover:foo hover:bar hover:baz hover:after:foo hover:after:bazThis proposes:
clsx({ hover: ["foo", "bar", "baz", { after: ["foo", "baz"] }] });Please excuse the reformatting of code :)