Pass on click events with defaultPrevented #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest not reacting to click events with property `defaultPrevented` set to true, as I'd assume the intention of `preventDefault` upstream was to prevent navigation. What do you think?
|
I think @jacwright beat you to it here #12 😄 |
|
That may be, but this PR has a very accurate title, describing it's contents exactly, unlike #12 ! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest not reacting to click events with property
defaultPreventedset to true, as I'd assume the intention ofpreventDefaultupstream was to prevent navigation.What do you think?