Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added information for assert.match and assert.not.match #118

Merged
merged 3 commits into from Jun 6, 2021
Merged

docs: added information for assert.match and assert.not.match #118

merged 3 commits into from Jun 6, 2021

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Jun 5, 2021

Hello!

On assert documentation, there is no mention of assert.match and assert.not.match. So, I've added those along with some simple examples.

Thanks!

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch! Just a couple of minor things. Wanted to highlight how the string-vs-regexp worked. Also removed the 3rd example case because it wasn't contributing anything.

docs/api.assert.md Outdated Show resolved Hide resolved
docs/api.assert.md Outdated Show resolved Hide resolved
docs/api.assert.md Outdated Show resolved Hide resolved
docs/api.assert.md Outdated Show resolved Hide resolved
@aldy505 aldy505 requested a review from lukeed June 6, 2021 04:04
Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukeed lukeed merged commit 271b7f1 into lukeed:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants