fix: type defs for a suite takes a context
#56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 3 3
Lines 305 305
=======================================
Hits 275 275
Misses 30 30 Continue to review full report at Codecov.
|
src/index.d.ts
Outdated
| @@ -19,5 +19,5 @@ declare namespace uvu { | |||
| type Context = Record<string, any>; | |||
| export const test: uvu.Test<Context>; | |||
| export type Callback<T=Context> = uvu.Callback<T>; | |||
| export function suite<T=Context>(title?: string, suite?: T): uvu.Test<T>; | |||
| export function suite<T=Context>(title?: string, context?: Partial<T>): uvu.Test<T>; | |||
There was a problem hiding this comment.
What do you think about this Partial @lukeed? I wanted this to be stuff like sync config, that get's enhanced by future before's... But don't want to have TS say context?.myThing always, but making the property be myThing?: string for example.
There was a problem hiding this comment.
It can't be enforced here. It's just forwarding whatever you decide the context contains. Entirely up to you & uvu types shouldn't mess with that.
|
Oops, thanks :) |
You don't pass a
suiteto the suite method, you pass acontext. 馃憖