fix bug in POST endpoint where it would timeout

[JakeChampion]

The toSearch function was never returning false because the find function returns null if it can not find a Todo record.

Adding a new function called exists which will always return a boolean. true if the record exists and false if it does not.

[lukeed]

Hey, thanks! But Model.find returns DB.read, which is Promise<T|false>. So result is going to be something truthy (the data) or false. The changes here are functionally the same thing

[JakeChampion]

Hey, thanks! But Model.find returns DB.read, which is Promise<T|false>. So result is going to be something truthy (the data) or false. The changes here are functionally the same thing

Except in the scenario where no TODOs or users exist, then it gets stuck in an infinite loop and hits the cloudflare worker timeout scenario. When no TODOs exist, the DB.read looks to return null, which is falsey but the check in DB.until is doing a strict non-equality check for false --

worktop/src/kv.ts

Line 36 in 21a6af9

while (exists !== false) {

This screenshot shows the user jake has no todos

This screenshot shows the timeout error that happens when a POST request is made to add a todo to jake

[JakeChampion]

I added a console.log inside the DB.until toSearch function to show what the result from find is:

[lukeed]

Ah shoot, sorry – you're right. DB.read is supposed to be checking x != null ? x : false

[lukeed]

Please remove this new utility. It's redundant as find() serves the same purpose. This PR should only have a fix to DB.read

[JakeChampion]

I've rebased all changes now into aca4266 (#19), it looks like typescript compiler is compiling into syntax which node12 does not support -- https://github.com/lukeed/worktop/runs/2209343024

[lukeed]

Ah, sorry. This is esbuild modernizing the output. Forgot it would "upgrade" syntax. I'll update that

[lukeed]

Sorry for the noise, thought I could get away with doing this via web editor only... nope 😅
Thanks!

[JakeChampion]

Hurrah! I'm glad I reported this as I thought it was a bug in the example but it was really a little bug in worktop itself. Thank you for figuring that out and helping me with the pull-request

[lukeed]

Yeah :) All apps had .then(x => x || false) but I wanted to accommodate the fact that someone may want to store 0, so I changed it at the last minute & forgot about the null empty value 🤦

Thanks again, will go out in next release