-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REQUIRE_EMAIL_CONFIRM setting #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test to
in TestMustVerify
to make sure that it returns False
if REQUIRE_EMAIL_CONFIRM
is False
, even if the other conditions are met?
|
||
@staticmethod | ||
def may_pass(url): | ||
try: | ||
return getattr( | ||
resolve(url).func, 'allow_without_verified_email', False) | ||
resolve(url).func, 'allow_without_verified_email', False) or not settings.REQUIRE_EMAIL_CONFIRM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need this here as well.
@@ -11,6 +11,8 @@ | |||
|
|||
SECRET_KEY = os.environ['SECRET_KEY'] | |||
|
|||
REQUIRE_EMAIL_CONFIRM = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is true in base it's probably not worthwhile setting it to True
here.
Signed-off-by: Walker Crouse <walkercrouse@hotmail.com>
@lukegb Updated |
f877717
to
6c117b1
Compare
Thanks! |
Signed-off-by: Walker Crouse walkercrouse@hotmail.com