Urlrefactor

[jnturton]

• Call node-mssql using URL instead of options object
• Encapsulate URL surgery in single class db-connection-config.js
• Update test suite
• Connection test run against: SQL Server, Postgres, MySQL

[lukemurray]

Awesome, thanks for this.

[jnturton]

If you can hold off on a new release for a little bit I should be able to sort out #34 too. As well as getting sql-server-manager.js to keep a single connection object alive between queries (currently it's a new connection every query) so that SQL Server session objects like #temp tables can be used across queries.

[lukemurray]

Sorry already went out. Both of those things would be great though. It's easy to push another release when they are ready.

Is the second one (keeping a single connection) a regression from this PR? Or did it do that previously? I forget the implementation and don't have access to MS SQL now.

[jnturton]

It's not a regression, the previous implementation obtains a new connection for every query.

…

On 01/03/2017 06:00, Luke Murray wrote: Sorry already went out. Both of those things would be great though. It's easy to push another release when they are ready. Is the second one (keeping a single connection) a regression from this PR? Or did it do that previously? I forget the implementation and don't have access to MS SQL now. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#113 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIr3d8UcSVNR-ezHGQd5JPn6QLs0EFTLks5rhO1JgaJpZM4L_GSY>.